[poppler] Poppler 0.23.2 (0.24 Beta 2) released

[Hib Eris]

Hi all,

On Tue, Jun 11, 2013 at 1:03 AM, Albert Astals Cid <aacid at kde.org> wrote:
>
> Available from
> http://poppler.freedesktop.org/poppler-0.23.2.tar.xz
>
>
> Testing, patches and bug reports welcome.
>

Building 0.23.2 for windows fails for me with this error message:

stress-threads-qt4.cpp: In member function 'virtual void CrazyThread::run()':
stress-threads-qt4.cpp:99:49: error: invalid static_cast from type
'Qt::HANDLE {aka void*}' to type 'uint {aka unsigned int}'
     qsrand(static_cast< uint >(currentThreadId()));
                                                 ^

According to documentation, 'The handle returned by this function
[currentThreadId] is used for internal purposes and should not be used
in any application code.'  [1]

It fails for Windows because 'On Windows, the returned value is a
pseudo-handle for the current thread. It can't be used for numerical
comparison. i.e., this function returns the DWORD (Windows-Thread ID)
returned by the Win32 function getCurrentThreadId(), not the HANDLE
(Windows-Thread HANDLE) returned by the Win32 function
getCurrentThread().' [1]


Has anyone a good idea how to fix this code?


Hib Eris




[1] http://qt-project.org/doc/qt-4.8/qthread.html#currentThread