[poppler] [PATCH] MinGW32 may or may not define __MINGW_PRINTF_FORMAT

Hib Eris hib at hiberis.nl
Tue Jun 11 02:58:45 PDT 2013


On Tue, Jun 11, 2013 at 10:02 AM, Peter Breitenlohner <peb at mppmu.mpg.de> wrote:
> Moreover __USE_MINGW_ANSI_STDIO might be defined as 0
>
> Signed-off-by: Peter Breitenlohner <peb at mppmu.mpg.de>
> ---
>  poppler/poppler-config.h.cmake | 2 +-
>  poppler/poppler-config.h.in    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/poppler/poppler-config.h.cmake b/poppler/poppler-config.h.cmake
> index af534c9..71a3278 100644
> --- a/poppler/poppler-config.h.cmake
> +++ b/poppler/poppler-config.h.cmake
> @@ -158,7 +158,7 @@ char * strtok_r (char *s, const char *delim, char **save_ptr);
>  //------------------------------------------------------------------------
>
>  #if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ > 4)
> -#ifdef __USE_MINGW_ANSI_STDIO
> +#ifdef __MINGW_PRINTF_FORMAT
>  #define GCC_PRINTF_FORMAT(fmt_index, va_index) \
>         __attribute__((__format__(__MINGW_PRINTF_FORMAT, fmt_index, va_index)))
>  #else
> diff --git a/poppler/poppler-config.h.in b/poppler/poppler-config.h.in
> index 51705e8..c5e181c 100644
> --- a/poppler/poppler-config.h.in
> +++ b/poppler/poppler-config.h.in
> @@ -158,7 +158,7 @@ char * strtok_r (char *s, const char *delim, char **save_ptr);
>  //------------------------------------------------------------------------
>
>  #if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ > 4)
> -#ifdef __USE_MINGW_ANSI_STDIO
> +#ifdef __MINGW_PRINTF_FORMAT
>  #define GCC_PRINTF_FORMAT(fmt_index, va_index) \
>         __attribute__((__format__(__MINGW_PRINTF_FORMAT, fmt_index, va_index)))
>  #else
> --
> 1.8.2.2

Indeed, this is a better way to handle this. Thanks for correcting me.

Hib Eris


More information about the poppler mailing list