[poppler] PATCH for crash in Page::removeAnnot

Carlos Garcia Campos carlosgc at gnome.org
Thu Jun 27 00:15:05 PDT 2013


Fabio D'Urso <fabiodurso at hotmail.it> writes:

> The attached patch fixes a crash in Page::removeAnnot, which blindly assumes 
> /Annots only contains Ref objects. Some PDF creators embed links (which are 
> Dictionaries) in the /Annots array, and this makes us abort() with
>
> Error (0): Call to Object where the object was type 7, not the expected type 9
>
> when we stumble on such a link.
>
> This patch adds a check to skip non-Ref entries (regular annotations *are* Ref 
> entries).

Looks good, pushed to git master.

> Test document (recycled from another bug, turns out it wasn't that useless :D)
>  https://bugs.freedesktop.org/attachment.cgi?id=63393&action=edit
>
> Steps to reproduce:
>  1. Open the document
>  2. Add new annotation
>  3. Remove it
>  4. abort() gets called
>
> Thanks,
> Fabio

Thanks!
-- 
Carlos Garcia Campos
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20130627/0a8443c6/attachment.pgp>


More information about the poppler mailing list