[poppler] Can anyone have a look at my patch?

Adrian Johnson ajohnson at redneon.com
Fri Oct 31 03:44:25 PDT 2014


On 31/10/14 09:31, Albert Astals Cid wrote:
> Hi guys, i made a patch for PSOutputDev and i think it's good, but extra set 
> of eyes are never a bad thing.
> 
> https://bugs.freedesktop.org/attachment.cgi?id=108708
> 
> Basically it's so that you don't have to pass firstPage-lastPage to PSOutputDev 
> and can simply pass an arbitrary set of pages.

Other than the issue Adam found with using the vector offset instead of
the page number in the error message the rest looks good.

> 
> Thanks,
>   Albert
> 
> P.S: Yes i know i have lots of patches in the queue to review
> P.S.2: I was planning to release 0.28 today but maybe tomorrow or over the 
> weekend, i'd like to at least get 
> https://bugs.freedesktop.org/show_bug.cgi?id=81724 and 
> https://bugs.freedesktop.org/show_bug.cgi?id=85234 in.

Would be nice to get this one resolved:
https://bugs.freedesktop.org/show_bug.cgi?id=58906

> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
> 



More information about the poppler mailing list