[poppler] Openjpeg2 patches: Why de-inline doGetChar?

[Albert Astals Cid]

El Dilluns, 5 de gener de 2015, a les 08:53:26, Adrian Johnson va escriure:
> On 05/01/15 08:39, Albert Astals Cid wrote:
> > Adrian, any reason you de-inlined doGetChar in the patches for openjpeg2?
> > 
> > As far as i remember when i made this function inline it got us a not so
> > bad free speed increase.
> 
> When I wrote the patch I moved all openjpeg specific types and code into
> the .cc file. I could not figure out how to make an inline function in
> the .h access the JPXStreamPrivate struct that is defined in the .cc file.

I see :/

Cheers,
  Albert

> 
> > Cheers,
> > 
> >   Albert
> > 
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler