[poppler] RFC: Expose whole-words search option in Qt frontends

[Adam Reichold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello again,

Am 11.01.2015 um 00:57 schrieb Albert Astals Cid:
> El Diumenge, 11 de gener de 2015, a les 00:37:36, Adam Reichold va
> escriure:
>> Hello,
>> 
>> Am 10.01.2015 um 23:45 schrieb Albert Astals Cid:
>>> Maybe you can add some tests to check_search.cpp?
>> 
>> Attached patch with a test case for the four flag combinations
>> added to the Qt4 and Qt5 versions of "check_search.cpp".
>> 
>> Of course, this very much highlights the ugliness of shoe horning
>> the flags into the existing enumeration. But I don't think that
>> making "Poppler::Page::search" take an "int" instead of
>> "SearchMode" would be ABI compatible strictly speaking, since now
>> the compiler is free to choose the underlying type for the
>> enumeration.
> 
> Meh, you're right, this is not good either since you're passing in
> SearchMode something that is not a SearchMode (it's the sum of
> two).
> 
> So yeah it'd be better to go the QFlags way. Maybe you can leave
> the old function there, mark it as deprecated and say that it only
> obeys the sensitiviness part and add a new function that accepts
> the qflags?

Ok, attached is the patch which adds a new flags type SearchFlags and
corresponding overloads to the Qt4 frontend. I try to factor out as
much common code as possible and add a test case as well. I'll add the
Qt5 frontend as soon we think the approach is sound.

I chose to use a new enumeration SearchFlag instead of SearchMode
since the symmetry of SearchMode does not really make sense if there
are several non-exclusive flags.

Best regards, Adam.

> Cheers, Albert
> 
>> 
>> Best regards, Adam.
>> 
>>> Cheers, Albert
>>> 
>>> El Dissabte, 10 de gener de 2015, a les 23:26:01, Adam Reichold
>>> va
>>> 
>>> escriure:
>>>> Hello again,
>>>> 
>>>> Am 10.01.2015 um 22:25 schrieb Albert Astals Cid:
>>>>> El Dissabte, 10 de gener de 2015, a les 17:51:48, Adam
>>>>> Reichold va
>>>>> 
>>>>> escriure:
>>>>>> Hello,
>>>>>> 
>>>>>> Attach is a patch that would expose Poppler's
>>>>>> whole-words search option within the Qt frontends.
>>>>>> 
>>>>>> While the implementation seems straight forward so far,
>>>>>> I would like to request comments whether extending the 
>>>>>> "SearchMode" enumeration to flag definition is
>>>>>> considered harmless. The proper way to do it seems to be
>>>>>> the introduction of "QFlags<SearchMode>" which would
>>>>>> however break compatibility and hence imply the need to
>>>>>> have an additional overloads using a separate flag (and
>>>>>> enumeration?) definition.
>>>>> 
>>>>> Looks good to me. The qt5/ side would need the
>>>>> documentation update too, no?
>>>> 
>>>> patch with fixed Qt5 documentation and "\since" commands 
>>>> attached.
>>>> 
>>>> Best regards, Adam.
>>>> 
>>>>> Cheers, Albert
>>>>> 
>>>>>> Best regards, Adam.
>>>>> 
>>>>> _______________________________________________ poppler 
>>>>> mailing list poppler at lists.freedesktop.org 
>>>>> http://lists.freedesktop.org/mailman/listinfo/poppler
>>> 
>>> _______________________________________________ poppler
>>> mailing list poppler at lists.freedesktop.org 
>>> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> _______________________________________________ poppler mailing
> list poppler at lists.freedesktop.org 
> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJUskzvAAoJEPSSjE3STU34Zt0H/3mCeTF91/udHJ2BfnIAgT3o
H4sdxddOCIBTNugH8vI5890HrlyUjb7IsoV3rntfePj/XWUERcCZViecrd3+qLdn
AL53Sg0m0lR9pEZA4KOxetM4GVl5flncxpQo9dq9dBFBnMUufOUT2PF8EXKZYyo7
h+te65+fOBOxI25Y2G4nsQxqJFSjhf66nYGJVC6f/JRu28MdTFgp1nzZ3941LRbm
pPF4rwZqju/yfF9HtNW1F1wctsoEzTEWQ4QMKf1FpLupFrxyHmMnuD5npbFLOSu6
68+R/K+p8b9PqMyC7F0NaVhlfT39NJ46z7idHlNFiuk8KImzFPunDhecax9OYrQ=
=zIMd
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: whole-words-proper.diff
Type: text/x-patch
Size: 13007 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20150111/2c0c8aad/attachment.bin>