[poppler] [RFC] Small string optimization in GooString
Albert Astals Cid
aacid at kde.org
Tue Jul 7 14:19:47 PDT 2015
El Dissabte, 4 de juliol de 2015, a les 12:58:52, Adam Reichold va escriure:
> Hello,
>
> Am 02.07.2015 um 00:38 schrieb Albert Astals Cid:
> >> Of course, it might not be reason enough to include the patch. Do you
> >> consider taking just the memory layout fix so that the misleading
> >> comment about the final object size is resolved?
> >
> > The simpler the better, and from there we can build up :)
>
> As discussed, attached is only the first part of the complete patch
> which adjusts GooString internal static buffer size computation so that
> the final object size will be 32 on both LP32 and LP64 architectures.
Can you please adjust the
"// you can tweak this number for a different speed/memory usage tradeoffs.
// In libc malloc() rounding is 16 so it's best to choose a value that
// results in sizeof(GooString) be a multiple of 16."
Which doesn't make sense anymore?
Cheers,
Albert
>
> Best regards, Adam.
More information about the poppler
mailing list