[poppler] [PATCH 1/4] SHA-384, SHA-512 hash functions strictly require 64-bit words.

[Adrian Johnson]

On 10/03/16 04:42, Alok Anand wrote:
> ---
>  goo/gtypes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/goo/gtypes.h b/goo/gtypes.h
> index a8d4519..bd6e06c 100644
> --- a/goo/gtypes.h
> +++ b/goo/gtypes.h
> @@ -48,5 +48,5 @@ typedef unsigned short Gushort;
>  typedef unsigned int Guint;
>  typedef unsigned long Gulong;
>  typedef long long Goffset;
> -
> +typedef unsigned long long Guoffset;
>  #endif
> 

I can't see why we need this. Looking at the rest of the code, Guoffset
is used for byte counts and bit manipulation, not file offsets. So you
should use uint64_t instead (which is already defined in gtypes_p.h).