[poppler] Bug in GfxState.cc. What's the fix?

Albert Astals Cid aacid at kde.org
Tue May 3 23:40:33 UTC 2016


If you look at line 5550 of GfxState.cc you'll see

	  p->color[0][1].c[j] = patchesA[nPatchesA-1].color[1][0].c[j];
	  p->color[0][1].c[j] = patchesA[nPatchesA-1].color[0][0].c[j];

If you look carefully enough you see as we're setting a value and then 
immediately overwriting it \o/

I've no idea of what this code does but by symmetry with line 5724 i'd say it 
should be

	  p->color[0][0].c[j] = patchesA[nPatchesA-1].color[1][0].c[j];
	  p->color[0][1].c[j] = patchesA[nPatchesA-1].color[0][0].c[j];

Opinions?

Cheers,
  Albert


More information about the poppler mailing list