[poppler] [PATCH] upstreaming some LibreOffice patches

[Albert Astals Cid]

El dimarts, 1 de novembre de 2016, a les 16:10:06 CET, Stephan Bergmann va escriure:
> On 10/29/2016 12:28 AM, Albert Astals Cid wrote:
> > El dijous, 27 d’octubre de 2016, a les 15:39:39 CEST, Michael Stahl va
> > 
> > escriure:
> >> hi,
> > 
> > 003 is already fixed in our code, for 4 and 5, can we have files that show
> > those ubsan errors?
> 
> * For
> 0004-Work-around-fsanitize-shift.patch, an input file that shows the
> error is
> 
> <https://cgit.freedesktop.org/libreoffice/core/plain/sd/qa/unit/data/pdf/txtpic.pdf?id=acf531be6a423f9b74997b29a8cafe82aa18423c>:

Oh, i didn't realize this is for the unmaintained self-grown DCTStream decoder, any reason you're not using the libjpeg based one?

Honestly i'm a bit hesitant to touch code that we recommend people not to use.

> * For 0005-Avoid-UBSan-warning-about-undefined-downcast.patch, an input
> file that shows the error is
> <https://cgit.freedesktop.org/libreoffice/core/plain/xmlsecurity/qa/unit/pdf
> signing/data/good.pdf?id=acf531be6a423f9b74997b29a8cafe82aa18423c> (and the
> error is as given in the patch's commit message).

Fixed in what i think is a less invasive way (at least the diff is easier to read).
https://cgit.freedesktop.org/poppler/poppler/commit/?id=f43cb73939f85952d83afc87a6dc638dc1ae311b

Cheers,
  Albert