[poppler] [PATCH] upstreaming some LibreOffice patches

Stephan Bergmann sbergman at redhat.com
Wed Nov 2 10:32:44 UTC 2016


On 11/02/2016 12:27 AM, Albert Astals Cid wrote:
> El dimarts, 1 de novembre de 2016, a les 16:10:06 CET, Stephan Bergmann va escriure:
>> * For
>> 0004-Work-around-fsanitize-shift.patch, an input file that shows the
>> error is
>>
>> <https://cgit.freedesktop.org/libreoffice/core/plain/sd/qa/unit/data/pdf/txtpic.pdf?id=acf531be6a423f9b74997b29a8cafe82aa18423c>:
>
> Oh, i didn't realize this is for the unmaintained self-grown DCTStream decoder, any reason you're not using the libjpeg based one?

Sorry, I at least don't have a real idea how LibreOffice uses poppler.

>> * For 0005-Avoid-UBSan-warning-about-undefined-downcast.patch, an input
>> file that shows the error is
>> <https://cgit.freedesktop.org/libreoffice/core/plain/xmlsecurity/qa/unit/pdf
>> signing/data/good.pdf?id=acf531be6a423f9b74997b29a8cafe82aa18423c> (and the
>> error is as given in the patch's commit message).
>
> Fixed in what i think is a less invasive way (at least the diff is easier to read).
> https://cgit.freedesktop.org/poppler/poppler/commit/?id=f43cb73939f85952d83afc87a6dc638dc1ae311b

I can confirm that patch works fine (at least as far as the LibreOffice 
test suite is concerned).


More information about the poppler mailing list