[poppler] Second opinion for patch

[Albert Astals Cid]

El dijous, 17 de novembre de 2016, a les 17:48:24 CET, Carlos Garcia Campos va 
escriure:
> Albert Astals Cid <aacid at kde.org> writes:
> > Can someone have a look at
> > https://bugs.freedesktop.org/show_bug.cgi?id=98732
> > 
> > I'd like a second opinion on the patch, it fixes the problem on that
> > broken
> > file for me but before commiting i'd like to know i'm not missing
> > something.
> I guess the file is broken because "Last" is required field in outline
> dictionary. In that case I would keep using Last if present, and simply
> remove the early return in OutlineItem::readItemList() otherwise.

Yes it's broken, the file does have a "Last", it's just that the "Last" 
doesn't really point to the last but to somehwere in the middle (if you use 
the next->next->next).

Given that Adobe Reader shows all of the items i guess it also ignores it and 
just relies on next.

Cheers,
  Albert

> 
> > Cheers,
> > 
> >   Albert
> > 
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/poppler