[poppler] poppler Digest, Vol 146, Issue 21
Boutouba Miloud
miloud.boutouba at etud.univ-paris8.fr
Wed Apr 26 17:03:58 UTC 2017
----- Mail original -----
De: "poppler-request" <poppler-request at lists.freedesktop.org>
À: "poppler" <poppler at lists.freedesktop.org>
Envoyé: Mercredi 26 Avril 2017 14:00:02
Objet: poppler Digest, Vol 146, Issue 21
Send poppler mailing list submissions to
poppler at lists.freedesktop.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.freedesktop.org/mailman/listinfo/poppler
or, via email, send a message with subject or body 'help' to
poppler-request at lists.freedesktop.org
You can reach the person managing the list at
poppler-owner at lists.freedesktop.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of poppler digest..."
Today's Topics:
1. Bug form with radio button (Boutouba Miloud)
2. poppler/XRef.cc (Albert Astals Cid)
3. poppler/XRef.cc (Albert Astals Cid)
4. Re: Bug form with radio button (Albert Astals Cid)
----------------------------------------------------------------------
Message: 1
Date: Tue, 25 Apr 2017 16:21:00 +0200 (CEST)
From: Boutouba Miloud <miloud.boutouba at etud.univ-paris8.fr>
To: poppler at lists.freedesktop.org
Subject: [poppler] Bug form with radio button
Message-ID:
<1482788864.4112518.1493130060738.JavaMail.zimbra at etud.univ-paris8.fr>
Content-Type: text/plain; charset="utf-8"
Hi everyone ,
I'd like to show you a bug that I found on evince. The bug is that you can't reach again a button radio selected by default after you have select another button.
https://bug746020.bugzilla-attachments.gnome.org/attachment.cgi?id=349309 , here is a basic attachment to see the bug.
To reproduce it, please open the attachment with evince and select another radio button (ex Water) and then try to reach again the button selected by default (Beer).
The bug was filed on evince bug tracker here https://bugzilla.gnome.org/show_bug.cgi?id=746020 (reported by Alain Knaff), but it seems don't coming from evince so it was also filed on poppler bug tracker https://bugs.freedesktop.org/show_bug.cgi?id=100535 (reported by Alexander Sellier).
We (me and Alexander Sellier) would like to fix it, can you help us please.
Thank you.
Miloud Boutouba
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20170425/4b17c09a/attachment-0001.html>
------------------------------
Message: 2
Date: Tue, 25 Apr 2017 17:44:24 +0000 (UTC)
From: aacid at kemper.freedesktop.org (Albert Astals Cid)
To: poppler at lists.freedesktop.org
Subject: [poppler] poppler/XRef.cc
Message-ID: <20170425174424.894C576189 at kemper.freedesktop.org>
poppler/XRef.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 278439531b13b0b047dbe3a75aa3f1b3407c8bd4
Author: Albert Astals Cid <aacid at kde.org>
Date: Tue Apr 25 19:42:15 2017 +0200
Fix memory leak (and probably logic bug) parsing broken XRef entries
Don't need to get obj1 again to ask if it's an int64 instead of an int
Bug #100775
diff --git a/poppler/XRef.cc b/poppler/XRef.cc
index e4caaab7..c141bbfe 100644
--- a/poppler/XRef.cc
+++ b/poppler/XRef.cc
@@ -1606,8 +1606,7 @@ GBool XRef::parseEntry(Goffset offset, XRefEntry *entry)
str->makeSubStream(offset, gFalse, 20, &obj)), gTrue);
Object obj1, obj2, obj3;
- if (((parser.getObj(&obj1)->isInt()) ||
- parser.getObj(&obj1)->isInt64()) &&
+ if (((parser.getObj(&obj1)->isInt()) || obj1.isInt64()) &&
(parser.getObj(&obj2)->isInt()) &&
(parser.getObj(&obj3)->isCmd("n") || obj3.isCmd("f"))) {
if (obj1.isInt64())
------------------------------
Message: 3
Date: Tue, 25 Apr 2017 17:49:26 +0000 (UTC)
From: aacid at kemper.freedesktop.org (Albert Astals Cid)
To: poppler at lists.freedesktop.org
Subject: [poppler] poppler/XRef.cc
Message-ID: <20170425174926.A73F276189 at kemper.freedesktop.org>
poppler/XRef.cc | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
New commits:
commit b21b041f7948680c03109f0c404400a9dbc4544c
Author: Albert Astals Cid <aacid at kde.org>
Date: Tue Apr 25 19:48:24 2017 +0200
Fix memory leak when reconstructing broken files
Need to free the catalog variable if we're going to fetch over it again
Bug #100776
diff --git a/poppler/XRef.cc b/poppler/XRef.cc
index c141bbfe..6ea0fbb6 100644
--- a/poppler/XRef.cc
+++ b/poppler/XRef.cc
@@ -1144,13 +1144,16 @@ GBool XRef::okToAssemble(GBool ignoreOwnerPW) {
}
Object *XRef::getCatalog(Object *catalog) {
- Object *obj = fetch(rootNum, rootGen, catalog);
- if (obj->isDict()) {
- return obj;
+ fetch(rootNum, rootGen, catalog);
+ if (catalog->isDict()) {
+ return catalog;
}
GBool wasReconstructed = false;
- GBool ok = constructXRef(&wasReconstructed, gTrue);
- return (ok) ? fetch(rootNum, rootGen, catalog) : obj;
+ if (constructXRef(&wasReconstructed, gTrue)) {
+ catalog->free();
+ fetch(rootNum, rootGen, catalog);
+ }
+ return catalog;
}
Object *XRef::fetch(int num, int gen, Object *obj, int recursion) {
------------------------------
Message: 4
Date: Tue, 25 Apr 2017 22:54:07 +0200
From: Albert Astals Cid <aacid at kde.org>
To: poppler at lists.freedesktop.org
Subject: Re: [poppler] Bug form with radio button
Message-ID: <8751036.WaJqDTa5m9 at xps>
Content-Type: text/plain; charset="UTF-8"
El dimarts, 25 d’abril de 2017, a les 16:21:00 CEST, Boutouba Miloud va
escriure:
> Hi everyone ,
Hi (please try not to send HTML mail unless you *really* need to)
>
> I'd like to show you a bug that I found on evince. The bug is that you can't
> reach again a button radio selected by default after you have select
> another button.
>
>
>
>
> https://bug746020.bugzilla-attachments.gnome.org/attachment.cgi?id=349309 ,
> here is a basic attachment to see the bug.
>
>
>
>
>
> To reproduce it, please open the attachment with evince and select another
> radio button (ex Water) and then try to reach again the button selected by
> default (Beer).
>
>
>
>
> The bug was filed on evince bug tracker here
> https://bugzilla.gnome.org/show_bug.cgi?id=746020 (reported by Alain
> Knaff), but it seems don't coming from evince so it was also filed on
> poppler bug tracker https://bugs.freedesktop.org/show_bug.cgi?id=100535
> (reported by Alexander Sellier).
>
>
>
>
> We (me and Alexander Sellier) would like to fix it, can you help us please.
Have you done anything?
I mean what do you need help with?
Cheers,
Albert
>
>
>
>
> Thank you.
>
>
>
>
> Miloud Boutouba
I took a look on the pdf (see attachment) with a text editor, and I've found something interesting.
Firsly, the pdf have this information about the button selected by default:
/Parent 8 0 R
/Ff 49152
/V /Beer
/DA (/F4 12.000000 Tf 0g)
When I've changed the button (for example Water) and saved.
I found that the pdf still have this same above information despite the button selected is Water (not Beer).
The bug seems coming from there, I mean the button selected by default still say : I'm parent.
Thanks.
------------------------------
Subject: Digest Footer
_______________________________________________
poppler mailing list
poppler at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/poppler
------------------------------
End of poppler Digest, Vol 146, Issue 21
****************************************
More information about the poppler
mailing list