[poppler] Merging the better_object branch for Poppler 0.58

[Albert Astals Cid]

El dimarts, 1 d’agost de 2017, a les 7:26:21 CEST, Jüttner, Hans-Ulrich va 
escriure:
> Hello,
> 
> On Tue, Aug 08, 2017 at 0:17 AM, Albert Astals Cid wrote:
> 
> > El dimarts, 20 de juny de 2017, a les 0:32:37 CEST, Albert Astals Cid va
> > escriure:
> > 
> >> This wednesday i'll release Poppler 0.56 (if all goes according to
> >> plan).
> >>
> >>
> >>
> >> Then around 20 July (may get delayed since that day starts the KDE
> >> yearly
> >> conference) i'll release Poppler 0.57.
> >>
> >>
> >>
> >> My plan is just after doing the 0.57 release merging the better_object
> >> branch to master
> > 
> > This is now done, let's hope not much broke ^_^
> 
> 
> I just pulled the latest changes and they even doesn't compile.

i've fixed it yesterday, you're using openjpeg1 which i am not, note that as 
described in another email this week, openjpeg1 support will go away at the 
end of the year, you should start using openjpeg2.

Cheers,
  Albert

> The first error was:
>    CXX      libpoppler_la-JPEG2000Stream.lo
> JPEG2000Stream.cc: In member function 'void JPXStream::init()':
> JPEG2000Stream.cc:199:51: error: invalid conversion from 'Object*' to 
> 'int' [-fpermissive]
>     if (getDict()) getDict()->lookup("Length", &oLen);
>                                                     ^
> In file included from Object.h:341:0,
>                   from JPEG2000Stream.h:22,
>                   from JPEG2000Stream.cc:19:
> Dict.h:77:10: error:   initializing argument 2 of 'Object 
> Dict::lookup(const char*, int)' [-fpermissive]
>     Object lookup(const char *key, int recursion = 0);
>            ^
> JPEG2000Stream.cc:200:57: error: invalid conversion from 'Object*' to 
> 'int' [-fpermissive]
>     if (getDict()) getDict()->lookup("ColorSpace", &cspace);
>                                                           ^
> In file included from Object.h:341:0,
>                   from JPEG2000Stream.h:22,
>                   from JPEG2000Stream.cc:19:
> Dict.h:77:10: error:   initializing argument 2 of 'Object 
> Dict::lookup(const char*, int)' [-fpermissive]
>     Object lookup(const char *key, int recursion = 0);
>            ^
> JPEG2000Stream.cc:201:63: error: invalid conversion from 'Object*' to 
> 'int' [-fpermissive]
>     if (getDict()) getDict()->lookup("SMaskInData", &smaskInData);
>                                                                 ^
> In file included from Object.h:341:0,
>                   from JPEG2000Stream.h:22,
>                   from JPEG2000Stream.cc:19:
> Dict.h:77:10: error:   initializing argument 2 of 'Object 
> Dict::lookup(const char*, int)' [-fpermissive]
>     Object lookup(const char *key, int recursion = 0);
>            ^
> In file included from JPEG2000Stream.h:22:0,
>                   from JPEG2000Stream.cc:19:
> Object.h:291:8: error: 'void Object::free()' is private
>     void free();
>          ^
> JPEG2000Stream.cc:205:13: error: within this context
>     oLen.free();
>               ^
> JPEG2000Stream.cc:209:31: error: invalid conversion from 'Object*' to 
> 'int' [-fpermissive]
>       cspace.arrayGet(0, &cstype);
>                                 ^
> In file included from JPEG2000Stream.h:22:0,
>                   from JPEG2000Stream.cc:19:
> Object.h:331:15: error:   initializing argument 2 of 'Object 
> Object::arrayGet(int, int)' [-fpermissive]
>   inline Object Object::arrayGet(int i, int recursion = 0)
>                 ^
> In file included from JPEG2000Stream.h:22:0,
>                   from JPEG2000Stream.cc:19:
> Object.h:291:8: error: 'void Object::free()' is private
>     void free();
>          ^
> JPEG2000Stream.cc:211:17: error: within this context
>       cstype.free();
>                   ^
> In file included from JPEG2000Stream.h:22:0,
>                   from JPEG2000Stream.cc:19:
> Object.h:291:8: error: 'void Object::free()' is private
>     void free();
>          ^
> JPEG2000Stream.cc:213:15: error: within this context
>     cspace.free();
>                 ^
> In file included from JPEG2000Stream.h:22:0,
>                   from JPEG2000Stream.cc:19:
> Object.h:291:8: error: 'void Object::free()' is private
>     void free();
>          ^
> JPEG2000Stream.cc:217:20: error: within this context
>     smaskInData.free();
> 
> 
> 
> >
> >
> > Cheers,
> > 
> >    Albert
> >
> >
> >
> >> so it gets released with Poppler 0.28 around 20 August.
> >>
> >>
> >>
> >> I'm almost convinced there will be some regression since the code diff
> >> is
> >> *huge*, but i'm also convinced it gives us a much nicer API to work with,
> >> in
 particular for "non hardcore contributors", see the missing free()
> >> in the patch at https://bugs.freedesktop.org/show_bug.cgi?id=99271 so in
> >> the long run we end up winning.
> >>
> >>
> >>
> >> This means you have two months since now until a version with the
> >> better_object code gets released, please review the branch as soon as
> >> possible.
> >>
> >>
> >>
> >> Cheers,
> >> 
> >>    Albert
> >> 
> >> _______________________________________________
> >> poppler mailing list
> >> poppler at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/poppler
> >
> >
> >
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/poppler
> 
> 
> -- 
> Dr. Hans-Ulrich Jüttner
> Software Development
> 
> Labor Dr. von Froreich - Bioscientia GmbH
> Großmoorbogen 25
> 21079 Hamburg
> Deutschland
> 
> Fon +49 (40) 766 96-305
> Fax +49 (40) 766 96-334
> Web www.froreich-bioscientia.de
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler