[poppler] Should this strcat be sprintf?

Adrian Johnson ajohnson at redneon.com
Sat Sep 2 10:50:35 UTC 2017


On 02/09/17 19:30, Albert Astals Cid wrote:
> in pdfinfo.cc
> 
> strcat(buf, "[ FitV null ");
> strcat(buf, "[ FitBV null ");
> 
> Looks like they're catting into an empty buffer?

Probably better to use GooString.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pdfinfo-use-GooString.append-instead-of-sprintf-strc.patch
Type: text/x-patch
Size: 3191 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20170902/3976f65d/attachment.bin>


More information about the poppler mailing list