[poppler] reconsideration about iconv() in cpp frontend

suzuki toshiya mpsuzuki at hiroshima-u.ac.jp
Wed Apr 18 04:35:46 UTC 2018


Albert Astals Cid wrote:
>>> Sure, is there any system where sizeof(unsigned short) != 2 anyway?
>> Maybe people feel "such system is out of scope", but there were:
>> https://web.archive.org/web/20090408221917/http://www.zib.de/benger/hdf5/Dat
>> atypes.html according to the description for "size_t H5Tget_precision (hid_t
>> type)", there is a note saying
>> "For instance, a short on a Cray is 32 significant bits in an eight-byte
>> field."
> 
> Yeah we don't care about Cray :D

So, I attached a revised patch which replacing ustring as
std::basic_string<uint16_t>, and removing conditionalized
codes for the platform where (uint16_t != unsigned short).

How about this?

Regards,
mpsuzuki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mps-fix-cpp-encoding-issue_20180418-1330.diff.xz
Type: application/octet-stream
Size: 2264 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20180418/18b42d0c/attachment.obj>


More information about the poppler mailing list