[poppler] qt5/src

Albert Astals Cid aacid at kemper.freedesktop.org
Tue Jan 2 23:33:10 UTC 2018


 qt5/src/poppler-annotation.cc |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 9f08b62ea283ea66b35cfc6dab3e7f45bc4170b9
Author: Albert Astals Cid <aacid at kde.org>
Date:   Wed Jan 3 00:32:23 2018 +0100

    qt5: Do not assume all Screen annotation actions are Renditions
    
    Fixes KDE bug #388175

diff --git a/qt5/src/poppler-annotation.cc b/qt5/src/poppler-annotation.cc
index dfd56906..dbe336dc 100644
--- a/qt5/src/poppler-annotation.cc
+++ b/qt5/src/poppler-annotation.cc
@@ -551,7 +551,11 @@ QList<Annotation*> AnnotationPrivate::findAnnotations(::Page *pdfPage, DocumentD
 
                 // -> screen
                 Link * popplerLink = PageData::convertLinkActionToLink( screenann->getAction(), doc, QRectF() );
-                s->setAction( static_cast<Poppler::LinkRendition *>(popplerLink) );
+                // TODO Support other link types than Link::Rendition in ScreenAnnotation
+                if (popplerLink->linkType() == Link::Rendition)
+                    s->setAction( static_cast<Poppler::LinkRendition *>(popplerLink) );
+                else
+                    delete popplerLink;
 
                 // -> screenTitle
                 GooString * screentitle = screenann->getTitle();


More information about the poppler mailing list