[poppler] poppler/StructTreeRoot.h

Albert Astals Cid aacid at kemper.freedesktop.org
Tue Jan 9 18:49:02 UTC 2018


 poppler/StructTreeRoot.h |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit c2711874a4afc00448c21e86fdaf0b7aec40b623
Author: Albert Astals Cid <aacid at kde.org>
Date:   Tue Jan 9 19:47:29 2018 +0100

    Fix another clazy rule-of-three warning
    
    We can just use the default copy assignemnt and constructor for Parent

diff --git a/poppler/StructTreeRoot.h b/poppler/StructTreeRoot.h
index 448b5f5f..cd94a472 100644
--- a/poppler/StructTreeRoot.h
+++ b/poppler/StructTreeRoot.h
@@ -68,10 +68,8 @@ private:
     StructElement *element;
 
     Parent(): element(nullptr) { ref.num = ref.gen = -1; }
-    Parent(const Parent &p): element(p.element) {
-      ref.num = p.ref.num;
-      ref.gen = p.ref.gen;
-    }
+    Parent(const Parent &p) = default;
+    Parent& operator=(const Parent &) = default;
     ~Parent() {}
   };
 


More information about the poppler mailing list