[poppler] poppler/Form.cc poppler/Form.h

Albert Astals Cid aacid at kemper.freedesktop.org
Tue Jun 26 13:28:21 UTC 2018


 poppler/Form.cc |   11 -----------
 poppler/Form.h  |    3 ---
 2 files changed, 14 deletions(-)

New commits:
commit b317ee3ecb939b91e1f8245177defaa59f8478b7
Author: Albert Astals Cid <aacid at kde.org>
Date:   Tue Jun 26 15:27:48 2018 +0200

    Form: Remove unused getContentCopy
    
    it's confusing to have getContent and getContentCopy that does 99% the same

diff --git a/poppler/Form.cc b/poppler/Form.cc
index 1e60461a..6f3b76fd 100644
--- a/poppler/Form.cc
+++ b/poppler/Form.cc
@@ -269,11 +269,6 @@ const GooString* FormWidgetText::getContent () const
   return parent()->getContent();
 }
 
-GooString* FormWidgetText::getContentCopy ()
-{
-  return parent()->getContentCopy();
-}
-
 void FormWidgetText::updateWidgetAppearance()
 {
   if (widget)
@@ -1202,12 +1197,6 @@ void FormFieldText::print(int indent)
 }
 #endif
 
-GooString* FormFieldText::getContentCopy ()
-{
-  if (!content) return nullptr;
-  return new GooString(content);
-}
-
 void FormFieldText::setContentCopy (const GooString* new_content)
 {
   delete content;
diff --git a/poppler/Form.h b/poppler/Form.h
index 097d2ab6..3e58a80a 100644
--- a/poppler/Form.h
+++ b/poppler/Form.h
@@ -195,8 +195,6 @@ public:
   FormWidgetText(PDFDoc *docA, Object *dict, unsigned num, Ref ref, FormField *p);
   //return the field's content (UTF16BE)
   const GooString* getContent() const;
-  //return a copy of the field's content (UTF16BE)
-  GooString* getContentCopy();
 
   //expects a UTF16BE string
   void setContent(const GooString* new_content);
@@ -419,7 +417,6 @@ public:
   FormFieldText(PDFDoc *docA, Object *dict, const Ref& ref, FormField *parent, std::set<int> *usedParents);
   
   const GooString* getContent () const { return content; }
-  GooString* getContentCopy ();
   void setContentCopy (const GooString* new_content);
   ~FormFieldText();
 


More information about the poppler mailing list