[poppler] [PATCH] Less deprecated glib calls

Germán Poo-Caamaño gpoo at gnome.org
Tue Mar 27 22:17:18 UTC 2018


On Mon, 2018-03-26 at 21:45 +0200, Albert Astals Cid wrote:
> El dilluns, 26 de març de 2018, a les 19:45:57 CEST, Germán Poo-
> Caamaño va 
> escriure:
> > On Mon, 2018-03-26 at 19:34 +0200, Albert Astals Cid wrote:
> > > diff --git a/glib/demo/annots.c b/glib/demo/annots.c
> > > index 7f2e8618..bbcc31c2 100644
> > > --- a/glib/demo/annots.c
> > > +++ b/glib/demo/annots.c
> > > @@ -350,7 +350,7 @@ pgd_annots_update_cursor (PgdAnnotsDemo
> > > *demo,
> > > 
> > >       demo->cursor = cursor_type;
> > >       
> > >       gdk_window_set_cursor (gtk_widget_get_window (demo-
> > > >main_box),
> > > 
> > > cursor);
> > > -     gdk_flush ();
> > > +     gdk_display_flush (gtk_widget_get_display (demo-
> > > >main_box));
> > > 
> > >       if (cursor)
> > >       
> > >           g_object_unref (cursor);
> > >  
> > >  }
> > > 
> > > diff --git a/glib/demo/selections.c b/glib/demo/selections.c
> > > index eff099e2..d2f87eb6 100644
> > > --- a/glib/demo/selections.c
> > > +++ b/glib/demo/selections.c
> > > @@ -168,7 +168,7 @@ pgd_selections_update_cursor
> > > (PgdSelectionsDemo
> > > *demo,
> > > 
> > >  	demo->cursor = cursor_type;
> > >  	
> > >  	gdk_window_set_cursor (window, cursor);
> > > 
> > > -	gdk_flush ();
> > > +	gtk_widget_get_display (demo->darea);
> > 
> > It seems you are missing gdk_display_flush:
> > 
> > +     gdk_display_flush (gtk_widget_get_display (demo->darea));
> 
> Lol right, wrong copy&paste. Should I commit after fixing htat?

I think it is safe to do so, but I have no vote on what is committed or
not in Poppler :-)

-- 
Germán Poo-Caamaño
http://calcifer.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20180327/4a53a56b/attachment.sig>


More information about the poppler mailing list