[poppler] poppler/Gfx.cc

Albert Astals Cid aacid at kemper.freedesktop.org
Tue May 22 16:15:49 UTC 2018


 poppler/Gfx.cc |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit d1d8dea64db53fb151fede27efd5fd3308820a51
Author: Albert Astals Cid <aacid at kde.org>
Date:   Tue May 22 18:13:19 2018 +0200

    Fix memory leak on malformed files
    
    fixes oss-fuzz/8430

diff --git a/poppler/Gfx.cc b/poppler/Gfx.cc
index a4d12a70..bed1dc4b 100644
--- a/poppler/Gfx.cc
+++ b/poppler/Gfx.cc
@@ -1223,15 +1223,13 @@ void Gfx::opSetExtGState(Object args[], int numArgs) {
 	  }
 	  doSoftMask(&obj3, alpha, blendingColorSpace,
 		     isolated, knockout, funcs[0], &backdropColor);
-	  if (funcs[0]) {
-	    delete funcs[0];
-	  }
 	} else {
 	  error(errSyntaxError, getPos(), "Invalid soft mask in ExtGState - missing group");
 	}
       } else {
 	error(errSyntaxError, getPos(), "Invalid soft mask in ExtGState - missing group");
       }
+      delete funcs[0];
     } else if (!obj2.isNull()) {
       error(errSyntaxError, getPos(), "Invalid soft mask in ExtGState");
     }


More information about the poppler mailing list