[poppler] [PATCH 4/4] SplashXPathScanner: Reduce complexity of sorting spans

[Albert Astals Cid]

El dissabte, 26 de maig de 2018, a les 9:33:50 CEST, Adam Reichold va 
escriure:
> Hello Stefan,
> 
> Am 26.05.2018 um 04:34 schrieb Stefan Brüns:
> > To avoid large number of allocations for common simple polygons,
> > boost::container::small_vector<4, T> is used, which stores up to
> > 4 intersections inline. small_vector is a header-only class.
> 
> Even though it is header-only, it still means that Boost becomes a new
> build time dependency. Hence also CMakeLists.txt needs to adjust to find
> the Boost headers in possibly non-standard paths and giving a configure
> time error message if the necessary Boost headers are not present.
> 
> Personally, I would like it very much if Boost becomes a build time
> dependency for it contains many useful primitives and utilities. But I
> guess it would be best to reduce your XPathScanner patch to something
> purely based on the standard library - even if it allocates some more -
> and tackle the issue of using small_vector in a separate follow-up patch.

Yes please, no boost unless using it gives us a 200% speed increase or 
something.

Cheers,
  Albert

> 
> Also, maybe you would like to run this on a larger collection of
> documents to see a more statistical view of the performance
> improvements? Possibly, the attached perftest scripts helps with that.
> 
> Best regards,
> Adam