[poppler] poppler/Annot.cc

[GitLab Mirror]

 poppler/Annot.cc |   16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

New commits:
commit 08d4f02cdfa0f5ab0eccbc476f623dd334ce6432
Author: Tobias Deiminger <haxtibal at posteo.de>
Date:   Mon Nov 12 19:13:04 2018 +0100

    Fix parsing of line annotation LE values
    
    AnnotLine::initialize used to look for strings, which is wrong,
    because PDF reference says "LE [...] An array of two names".

diff --git a/poppler/Annot.cc b/poppler/Annot.cc
index 301aff29..76edfc9c 100644
--- a/poppler/Annot.cc
+++ b/poppler/Annot.cc
@@ -2971,16 +2971,20 @@ void AnnotLine::initialize(PDFDoc *docA, Dict *dict) {
     Object obj2;
 
     obj2 = obj1.arrayGet(0);
-    if (obj2.isString())
-      startStyle = parseAnnotLineEndingStyle(obj2.getString());
-    else
+    if (obj2.isName()) {
+      GooString leName(obj2.getName());
+      startStyle = parseAnnotLineEndingStyle(&leName);
+    } else {
       startStyle = annotLineEndingNone;
+    }
 
     obj2 = obj1.arrayGet(1);
-    if (obj2.isString())
-      endStyle = parseAnnotLineEndingStyle(obj2.getString());
-    else
+    if (obj2.isName()) {
+      GooString leName(obj2.getName());
+      endStyle = parseAnnotLineEndingStyle(&leName);
+    } else {
       endStyle = annotLineEndingNone;
+    }
 
   } else {
     startStyle = endStyle = annotLineEndingNone;