[poppler] 2 commits - goo/GooString.cc goo/GooString.h

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Nov 19 21:08:42 UTC 2019


 goo/GooString.cc |   10 ----------
 goo/GooString.h  |    3 +--
 2 files changed, 1 insertion(+), 12 deletions(-)

New commits:
commit 99f99aa9d475b0640a6efa0aca922c7eaf5bfdc0
Author: Albert Astals Cid <tsdgeos at yahoo.es>
Date:   Tue Nov 19 20:20:38 2019 +0000

    fix comment

diff --git a/goo/GooString.h b/goo/GooString.h
index 6543d833..5fccbe83 100644
--- a/goo/GooString.h
+++ b/goo/GooString.h
@@ -155,7 +155,7 @@ public:
   // Delete a character or range of characters.
   GooString *del(int i, int n = 1) { erase(i, n); return this; }
 
-  // Convert string to all-upper/all-lower case.
+  // Convert string to all-lower case.
   GooString *lowerCase();
 
   // Compare two strings:  -1:<  0:=  +1:>
commit 1417e6825b525eb09b67fdd80ddbbd33ce6eb5dc
Author: Oliver Sander <oliver.sander at tu-dresden.de>
Date:   Mon Nov 18 21:46:45 2019 +0100

    Remove GooString::upperCase
    
    It is never used.

diff --git a/goo/GooString.cc b/goo/GooString.cc
index 86fadf30..998c77ec 100644
--- a/goo/GooString.cc
+++ b/goo/GooString.cc
@@ -614,16 +614,6 @@ void formatDoubleSmallAware(double x, char *buf, int bufSize, int prec,
 
 }
 
-GooString *GooString::upperCase() {
-  for (auto& c : *this) {
-    if (std::islower(c)) {
-      c = std::toupper(c);
-    }
-  }
-
-  return this;
-}
-
 GooString *GooString::lowerCase() {
   for (auto& c : *this) {
     if (std::isupper(c)) {
diff --git a/goo/GooString.h b/goo/GooString.h
index 3bc8abbf..6543d833 100644
--- a/goo/GooString.h
+++ b/goo/GooString.h
@@ -156,7 +156,6 @@ public:
   GooString *del(int i, int n = 1) { erase(i, n); return this; }
 
   // Convert string to all-upper/all-lower case.
-  GooString *upperCase();
   GooString *lowerCase();
 
   // Compare two strings:  -1:<  0:=  +1:>


More information about the poppler mailing list