[poppler] poppler/SplashOutputDev.cc poppler/SplashOutputDev.h splash/Splash.cc splash/SplashPattern.h splash/SplashTypes.h

[Albert Astals Cid]

El divendres, 28 de febrer de 2020, a les 4:28:45 CET, William Bader va escriure:
> >I don't understand, didn't we fix that issue years ago already? I can't reproduce any problem with that file with the current released poppler version.
> 
> Yes, that was fixed five years ago and continues to work in 0.85.0, but I remembered that it used gouraudTriangleShadedFill() and it had a shaded rectangle that is processed as four triangles, so I thought that it might be useful to test the new code. Sorry about that. Regards, William

Ah you were worried it may regress, don't worry that file is part of our regression test.

Cheers,
  Albert

> 
> ________________________________
> From: Albert Astals Cid <aacid at kde.org>
> Sent: Thursday, February 27, 2020 6:34 PM
> To: poppler at lists.freedesktop.org <poppler at lists.freedesktop.org>
> Cc: William Bader <williambader at hotmail.com>
> Subject: Re: [poppler] poppler/SplashOutputDev.cc poppler/SplashOutputDev.h splash/Splash.cc splash/SplashPattern.h splash/SplashTypes.h
> 
> El dijous, 27 de febrer de 2020, a les 17:32:51 CET, William Bader va escriure:
> > >Unfortunately only implemented for shadings where the 3 vertices of the triangle have the same color for now since i got lost trying to implement the coloring (and also have no pdf to check against)
> >
> > Is the PDF with this fixed issue an example?
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=90570
> 
> I don't understand, didn't we fix that issue years ago already? I can't reproduce any problem with that file with the current released poppler version.
> 
> Cheers,
>   Albert
> 
> 
>