[poppler] What's your feeling in adding a _clang_format file to the repo

Albert Astals Cid aacid at kde.org
Sat Jun 20 09:07:39 UTC 2020


El dimecres, 17 de juny de 2020, a les 23:40:53 CEST, Albert Astals Cid va escriure:
> El dijous, 4 de juny de 2020, a les 22:53:26 CEST, Albert Astals Cid va escriure:
> > This way we would have a common style in the files, which we kind of but not really have.
> > 
> > Also, i'd suggest that common standard to not be the braindead mix of spaces + tabs that we inherited from xpdf and make it.
> > 
> > Attached my suggestion.
> > 
> > Problem is that it changes basically everything
> >  278 files changed, 102844 insertions(+), 109789 deletions(-)
> > 
> > So one would need to always use a --ignore-revs when doing git blame.
> > 
> > Opinions?
> 
> Since the vote is 2-0 for yes, i'll be doing this tomorrow.

Actually this has been postponed because clang-format makes poppler bug non-compilable :o

I'll be digging a bit more into it.

Cheers,
  Albert

> 
> Cheers,
>   Albert
> 
> > 
> > Albert
> 
> 
> 
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler
> 






More information about the poppler mailing list