[poppler] test/goostring-format-checker

[GitLab Mirror]

 test/goostring-format-checker/README                      |    2 +-
 test/goostring-format-checker/goostring-format-checker.cc |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 27258358cd0b82a762382b8f0aafe06abd698484
Author: Albert Astals Cid <aacid at kde.org>
Date:   Sat Jan 2 23:36:06 2021 +0100

    clang api changes

diff --git a/test/goostring-format-checker/README b/test/goostring-format-checker/README
index cc58a5d7..3be801c8 100644
--- a/test/goostring-format-checker/README
+++ b/test/goostring-format-checker/README
@@ -7,7 +7,7 @@
 	-Xclang -load -Xclang goostring-format-checker.so -Xclang -plugin -Xclang goostring-format-check
 
 Example:
-$ clang++ -shared -o goostring-format-checker.so goostring-format-checker.cc -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS
+$ clang++ -fPIC -shared -o goostring-format-checker.so goostring-format-checker.cc -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS
 $ export CXX=clang++
 $ export CXXFLAGS="-Xclang -load -Xclang $PWD/goostring-format-checker.so -Xclang -add-plugin -Xclang goostring-format-checker"
 $ mkdir build
diff --git a/test/goostring-format-checker/goostring-format-checker.cc b/test/goostring-format-checker/goostring-format-checker.cc
index 302772b2..41098561 100644
--- a/test/goostring-format-checker/goostring-format-checker.cc
+++ b/test/goostring-format-checker/goostring-format-checker.cc
@@ -6,6 +6,7 @@
  * Clang++ compiler plugin that checks usage of GooString::format-like functions
  *
  * Copyright (C) 2014 Fabio D'Urso <fabiodurso at hotmail.it>
+ * Copyright (C) 2021 Albert Astals Cid <aacid at kde.org>
  */
 
 #include <cctype>
@@ -341,7 +342,7 @@ private:
 class GooStringFormatCheckerAction : public PluginASTAction
 {
 protected:
-    ASTConsumer *CreateASTConsumer(CompilerInstance &compInst, llvm::StringRef inFile) { return new GooStringFormatCheckerConsumer(&compInst); }
+    std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &compInst, llvm::StringRef inFile) { return std::make_unique<GooStringFormatCheckerConsumer>(&compInst); }
 
     bool ParseArgs(const CompilerInstance &compInst, const std::vector<std::string> &args)
     {