[poppler] glib/poppler-structure-element.cc

[GitLab Mirror]

 glib/poppler-structure-element.cc |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1d91d03325662ca368cf5da77d09012998e7720e
Author: Nelson Benítez León <nbenitezl at gmail.com>
Date:   Mon Mar 1 00:22:26 2021 -0400

    glib/poppler-structure-element: fix memleak
    
    in convert_doubles_array(), which was not
    assigning the allocated memory to the
    out variable.
    
    This means this function was never returning
    anything until now, which means there's probably
    no users of this function in the wild (certainly
    not in Evince).
    
    Issue #1049

diff --git a/glib/poppler-structure-element.cc b/glib/poppler-structure-element.cc
index c63e9567..aec7cd15 100644
--- a/glib/poppler-structure-element.cc
+++ b/glib/poppler-structure-element.cc
@@ -1090,6 +1090,8 @@ static inline void convert_doubles_array(Object *object, gdouble **values, guint
     for (guint i = 0; i < *n_values; i++) {
         doubles[i] = object->arrayGet(i).getNum();
     }
+
+    values = &doubles;
 }
 
 static inline void convert_color(Object *object, PopplerColor *color)