[poppler] poppler/PDFDoc.cc

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 27 23:14:27 UTC 2022


 poppler/PDFDoc.cc |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 2e3c53b71f78b13f2afdb122c2d59243de70ac45
Author: Albert Astals Cid <aacid at kde.org>
Date:   Thu Jul 28 01:10:27 2022 +0200

    Fix leak in early return check that was just introduced

diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
index c26a41c4..80866602 100644
--- a/poppler/PDFDoc.cc
+++ b/poppler/PDFDoc.cc
@@ -887,7 +887,11 @@ int PDFDoc::savePageAs(const GooString &name, int pageNo)
     // get and mark output intents etc.
     Object catObj = getXRef()->getCatalog();
     if (!catObj.isDict()) {
-        error(errSyntaxError, -1, "XRef's Catelog is not a dictionary");
+        fclose(f);
+        delete yRef;
+        delete countRef;
+        delete outStr;
+        error(errSyntaxError, -1, "XRef's Catalog is not a dictionary");
         return errOpenFile;
     }
     Dict *catDict = catObj.getDict();


More information about the poppler mailing list