[poppler] Do we want to enable readability-braces-around-statements ?

Albert Astals Cid aacid at kde.org
Wed Mar 2 23:39:23 UTC 2022


It forces to add a pair of {} to all if/for/while/etc

https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1091

(it fails in Qt autogenerated files for now, i can fix that if we agree we want it)

I can see it being potentially annoying when CI fails because of this but on the other hand it seems it's always safer to include the braces to not fall into the trap of adding a line indented but that it's not really inside the if block

What do you'all think?

Cheers,
  Albert




More information about the poppler mailing list