[poppler] Is it acceptable if vcpkg patches in an inline namespace to avoid symbol clashes?

Billy O'Neal (VC AIR) bion at microsoft.com
Wed Dec 6 22:10:37 UTC 2023


Hello Poppler maintainers!

I'm reviewing a PR from a contributor to vcpkg which introduces an inline namespace when we install Poppler to avoid conflicts with other bits that want the name 'Parser'. See https://github.com/microsoft/vcpkg/pull/35472

We understand that you might not want to merge this as an upstream contribution since it's a workaround for something downstream of you. We still would like to make sure you won't hate us / think we're putting words in your mouth if we go ahead with it.

Can someone take a look and indicate that they don't outright hate this workaround?

Thanks!

Billy O'Neal
Visual C++ - vcpkg


More information about the poppler mailing list