[poppler] poppler/GPGMECryptoSignBackend.cc poppler/GPGMECryptoSignBackend.h

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 5 16:12:35 UTC 2023


 poppler/GPGMECryptoSignBackend.cc |    6 +++---
 poppler/GPGMECryptoSignBackend.h  |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit ee2af17e916e6310ab25b92a638df380b18a24ee
Author: Sune Vuorela <sune at vuorela.dk>
Date:   Wed Jul 5 17:30:46 2023 +0200

    Remove unused constructor parameter

diff --git a/poppler/GPGMECryptoSignBackend.cc b/poppler/GPGMECryptoSignBackend.cc
index a00eb230..6f82e266 100644
--- a/poppler/GPGMECryptoSignBackend.cc
+++ b/poppler/GPGMECryptoSignBackend.cc
@@ -163,9 +163,9 @@ GpgSignatureBackend::GpgSignatureBackend()
     GpgME::initializeLibrary();
 }
 
-std::unique_ptr<CryptoSign::SigningInterface> GpgSignatureBackend::createSigningHandler(const std::string &certID, HashAlgorithm digestAlgTag)
+std::unique_ptr<CryptoSign::SigningInterface> GpgSignatureBackend::createSigningHandler(const std::string &certID, HashAlgorithm /*digestAlgTag*/)
 {
-    return std::make_unique<GpgSignatureCreation>(certID, digestAlgTag);
+    return std::make_unique<GpgSignatureCreation>(certID);
 }
 
 std::unique_ptr<CryptoSign::VerificationInterface> GpgSignatureBackend::createVerificationHandler(std::vector<unsigned char> &&pkcs7)
@@ -195,7 +195,7 @@ std::vector<std::unique_ptr<X509CertificateInfo>> GpgSignatureBackend::getAvaila
     return certificates;
 }
 
-GpgSignatureCreation::GpgSignatureCreation(const std::string &certId, HashAlgorithm digestAlgTag) : gpgContext { GpgME::Context::create(GpgME::CMS) }
+GpgSignatureCreation::GpgSignatureCreation(const std::string &certId) : gpgContext { GpgME::Context::create(GpgME::CMS) }
 {
     GpgME::Error error;
     const auto signingKey = gpgContext->key(certId.c_str(), error, true);
diff --git a/poppler/GPGMECryptoSignBackend.h b/poppler/GPGMECryptoSignBackend.h
index 776dfc23..9cab07a7 100644
--- a/poppler/GPGMECryptoSignBackend.h
+++ b/poppler/GPGMECryptoSignBackend.h
@@ -25,7 +25,7 @@ public:
 class GpgSignatureCreation : public CryptoSign::SigningInterface
 {
 public:
-    GpgSignatureCreation(const std::string &certId, HashAlgorithm digestAlgTag);
+    GpgSignatureCreation(const std::string &certId);
     void addData(unsigned char *dataBlock, int dataLen) final;
     std::unique_ptr<X509CertificateInfo> getCertificateInfo() const final;
     std::optional<GooString> signDetached(const std::string &password) final;


More information about the poppler mailing list