<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Could the '4' be a constant, maybe PROCESS_NCOMPS?</p> I have only ever printed with four process colors (CMYK) plus one or two spot colors (special colors for advertisers). <div>What happens if you print with six or eight process colors plus a spot color? Does anyone actually do that? Should the 4 be a variable instead of a constant? Does anything with more than 4 process colors become DeviceN with the first four components CMYK, so the 4 would always be a 4 for CMYK even if you had more than 4 process colors?</div> <div>pdftops has to track the spot colors to set up the postscript custom colors correctly.</div> <div>Regards, William<br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> poppler <poppler-bounces@lists.freedesktop.org> on behalf of Stefan Brüns <stefan.bruens@rwth-aachen.de><br> <b>Sent:</b> Saturday, May 26, 2018 6:52 AM<br> <b>To:</b> poppler@lists.freedesktop.org<br> <b>Subject:</b> Re: [poppler] [PATCH] Correctly manipulate spot colors if SPOT_NCOMPS != 4</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Samstag, 26. Mai 2018 11:13:35 CEST Adam Reichold wrote:<br> > Hello again,<br> > <br> > Am 26.05.2018 um 10:55 schrieb Albert Astals Cid:<br> > > I don't really understand the patch, are you saying something like "the<br> > > code is correct, if you change it wrong it will break"? That happens in<br> > > lots of places ;)<br> > <br> > I guess the point is that the for loops should always start at i = 4<br> > (since dest[0..3] are handly outside) and should always go until NCOMPS + 4.<br> > <br> > The current code does this only if NCOMPS == 4 which is the default and<br> > why this currently works. But if NCOMPS != 4, the current code breaks as<br> > the for does not start with 4 anymore and leaves out dest[4..NCOMPS] and<br> > this patch fixes this.<br> > <br> > Best regards, Adam.<br> > <br> <br> Adams assessment is completely correct.<br> <br> Kind regards,<br> <br> Stefan<br> <br> -- <br> Stefan Brüns / Bergstraße 21 / 52062 Aachen<br> home: +49 241 53809034 mobile: +49 151 50412019</div> </span></font></div> </div> </div> </div> </body> </html>