<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Yes, anything more than 4 process becomes DeviceN. However making it a constant would seem to at least make the code clearer…<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Leonard<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> poppler <poppler-bounces@lists.freedesktop.org>
<b>On Behalf Of </b>William Bader<br>
<b>Sent:</b> Saturday, May 26, 2018 11:03 PM<br>
<b>To:</b> poppler@lists.freedesktop.org<br>
<b>Subject:</b> Re: [poppler] [PATCH] Correctly manipulate spot colors if SPOT_NCOMPS != 4<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div id="divtagdefaultwrapper">
<p><span style="font-size:12.0pt;color:black">Could the '4' be a constant, maybe PROCESS_NCOMPS?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">I have only ever printed with four process colors (CMYK) plus one or two spot colors (special colors for advertisers).
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">What happens if you print with six or eight process colors plus a spot color? Does anyone actually do that? Should the 4 be a variable instead of a constant? Does anything with more than 4 process
colors become DeviceN with the first four components CMYK, so the 4 would always be a 4 for CMYK even if you had more than 4 process colors?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">pdftops has to track the spot colors to set up the postscript custom colors correctly.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:12.0pt;color:black">Regards, William<o:p></o:p></span></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span style="font-size:12.0pt;color:black">
<hr size="3" width="98%" align="center">
</span></div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> poppler <<a href="mailto:poppler-bounces@lists.freedesktop.org">poppler-bounces@lists.freedesktop.org</a>> on behalf of Stefan Brüns <<a href="mailto:stefan.bruens@rwth-aachen.de">stefan.bruens@rwth-aachen.de</a>><br>
<b>Sent:</b> Saturday, May 26, 2018 6:52 AM<br>
<b>To:</b> <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [poppler] [PATCH] Correctly manipulate spot colors if SPOT_NCOMPS != 4</span><span style="font-size:12.0pt;color:black">
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"> <o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="color:black">On Samstag, 26. Mai 2018 11:13:35 CEST Adam Reichold wrote:<br>
> Hello again,<br>
> <br>
> Am 26.05.2018 um 10:55 schrieb Albert Astals Cid:<br>
> > I don't really understand the patch, are you saying something like "the<br>
> > code is correct, if you change it wrong it will break"? That happens in<br>
> > lots of places ;)<br>
> <br>
> I guess the point is that the for loops should always start at i = 4<br>
> (since dest[0..3] are handly outside) and should always go until NCOMPS + 4.<br>
> <br>
> The current code does this only if NCOMPS == 4 which is the default and<br>
> why this currently works. But if NCOMPS != 4, the current code breaks as<br>
> the for does not start with 4 anymore and leaves out dest[4..NCOMPS] and<br>
> this patch fixes this.<br>
> <br>
> Best regards, Adam.<br>
> <br>
<br>
Adams assessment is completely correct.<br>
<br>
Kind regards,<br>
<br>
Stefan<br>
<br>
-- <br>
Stefan Brüns / Bergstraße 21 / 52062 Aachen<br>
home: +49 241 53809034 mobile: +49 151 50412019<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>