<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">I haven't used VMS for about two decades, but I remember that the extra options to fopen() are important. Without them, I think that you end up with a record oriented file instead of a stream file, and stdio might not work as you expect, for example, writing '\n' might close the current record instead of writing a 0x0A byte. The full list of parameters is in the entry for creat() at <a href="http://h41379.www4.hpe.com/commercial/c/docs/5763p021.html#index_x_600" class="OWAAutoLink" id="LPlnk786712" previewremoved="true">http://h41379.www4.hpe.com/commercial/c/docs/5763p021.html#index_x_600</a></p> <div>HP sold VMS to a company that is porting it to <span>Intel x86-64, so VMS might soon be easier to run. <a href="http://www.openvms.org/node/107" class="OWAAutoLink" id="LPlnk678308" previewremoved="true">http://www.openvms.org/node/107</a></span><br> </div> Regards, William<br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> poppler <poppler-bounces@lists.freedesktop.org> on behalf of Martin (gzlist) <gzlist@googlemail.com><br> <b>Sent:</b> Sunday, June 24, 2018 8:05 AM<br> <b>To:</b> poppler@lists.freedesktop.org<br> <b>Subject:</b> Re: [poppler] Utils - Fix UTF-16 file name on Windows environment</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On 19/06/2018, Albert Astals Cid <aacid@kde.org> wrote:<br> ><br> > It does make some sense given that function exists in the first place but my<br> > experience with windows is veeeeeeeeeeeeery limited so I'd like for someone<br> > else to vouch for this before landing it.<br> <br> Overall the change might be, but there are some tricky aspects.<br> <br> On windows fopen takes a narrow string of variable codepage, and<br> openFile takes (sort-of*) utf-8 but the types are not distinguished in<br> the codebase so it's tricky to see what callers are providing.<br> <br> In cases where the string being used comes straight from say, the<br> command line or environment block, it will not be utf-8 so non-ascii<br> characters will be mangled. That's probably best fixed by ensuring on<br> GooString construction that it's converted to utf-8 but at present<br> that's entirely unvalidated.<br> <br> Also:<br> <br> #ifdef VMS<br> - f = fopen(fileName->getCString(), "rb", "ctx=stm");<br> + f = openFile(fileName->getCString(), "rb", "ctx=stm");<br> #else<br> - f = fopen(fileName->getCString(), "rb");<br> + f = openFile(fileName->getCString(), "rb");<br> #endif<br> <br> Breaks compilation on VMS (if that's still a platform that matters) as<br> openFile takes two args only. Oddly, GooFile::open already includes<br> this logic but openFile does not. Can just drop the first branch<br> change for now.<br> <br> Martin<br> <br> *sort-of utf-8: gfile.cc has a pretty half-assed utf-8 to utf-16<br> conversion algorithm in several places that only correctly handles a<br> subset of inputs.<br> _______________________________________________<br> poppler mailing list<br> poppler@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/poppler" id="LPlnk301186" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/poppler</a> <div id="LPBorder_GT_15298754333050.6659877018342264" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15298754333020.3046620153772779" role="presentation" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_15298754333030.5997815705012488" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_15298754333030.751505296069334"></div> <div id="LPTitle_15298754333030.7181755810847585" style="top: 0px; color: rgb(0, 120, 215); font-weight: 400; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15298754333030.330377264354641" href="https://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank" style="text-decoration: none;">poppler Info Page - freedesktop.org</a></div> <div id="LPMetadata_15298754333030.675304897490911" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15298754333040.6094931634005731" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> Subscribing to poppler: Subscribe to poppler by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </div> </body> </html>