<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
As far as I know, the SPLASH_CMYK flag adds support necessary for -level1sep to work dependably without breaking anything else.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Without SPLASH_CMYK, if a PDF has certain types of images and you use -level1sep, parts of poppler think that the image data is cmyk and parts of poppler think that the image data is rgb, and the image in the generated ps is messed up, like on an old style
analog television with vertical hold out of sync.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif; font-size: 12pt;">It is not very much additional code, and I never understood why it was a build option instead of always being included.</span></div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Maybe like OPI_SUPPORT it was experimental, and the flag should have been permanently enabled after the code was tested.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
William</div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> poppler <poppler-bounces@lists.freedesktop.org> on behalf of Adam Reichold <adam.reichold@t-online.de><br>
<b>Sent:</b> Tuesday, April 23, 2019 12:11 PM<br>
<b>To:</b> poppler@lists.freedesktop.org<br>
<b>Subject:</b> Re: [poppler] splashModeDeviceN8 in two switch</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Hello,<br>
<br>
thinking about this again with a bit of distance, should we maybe remove<br>
the `SPLASH_CMYK` preprocessor flag entirely? I am assuming the reasons<br>
for having this upstream is to keep the code from bit rotting as<br>
Poppler's internals change? If nobody builds this, then this will not<br>
happen. (CI checks improve things, but it will still be "late" feedback<br>
instead of being part of the initial edit-compile-test cycle. Also, this<br>
will not reach e.g. clusterfuzz which thereby will not verify that code.)<br>
<br>
Are there any downsides to removing the conditional compilation? Does<br>
this break code that does not request the CMYK handling explicitly? If<br>
so, could we fix this via the internal API instead of hard-coded it at<br>
compile time?<br>
<br>
Best regards,<br>
Adam<br>
<br>
Am 22.04.19 um 13:14 schrieb Albert Astals Cid:<br>
> This is mostly for William since AFAIK he's the "only" one using SPLASH_CMYK.<br>
> <br>
> I've tried to enable SPLASH_CMYK on the CI and it's loudly complaining that the splashModeDeviceN8 cases are missing in SplashOutputDev.cc<br>
> <br>
> <a href="https://gitlab.freedesktop.org/aacid/poppler/-/jobs/253647">https://gitlab.freedesktop.org/aacid/poppler/-/jobs/253647</a><br>
> <br>
> Any suggestion of what the code should be?<br>
> <br>
> Should they just be the same as case splashModeCMYK8: ? The first one looks like it may make sense, but not so sure about the second.<br>
> <br>
> Cheers,<br>
> Albert<br>
> <br>
> <br>
> _______________________________________________<br>
> poppler mailing list<br>
> poppler@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/poppler">https://lists.freedesktop.org/mailman/listinfo/poppler</a><br>
> <br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>