[Portland-bugs] [Bug 16027] New: xdg-screensaver doesn't support preferences GUI

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=16027

           Summary: xdg-screensaver doesn't support preferences GUI
           Product: Portland
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: xdg-utils
        AssignedTo: portland-bugs at lists.freedesktop.org
        ReportedBy: brian.cameron at sun.com


The gnome-panel code (in gnome-panel/panel-util.c) has hardcoded references to
the screensaver programs.  It seems it would be be good to get rid of the
hardcoded references to gnome-screensaver/xscreensaver commands and instead
just use xdg-screensaver.  However note that gnome-panel also needs to run the
preferences GUI program for the screensaver, so the preferences programs
(gnome-screensaver-preferences and xscreensaver-demo) are also hardcoded. 
However xdg-screensaver does not support any options to launch the preferences
GUI for the appropriate screensaver.

I think it would make sense for xdg-screensaver to support an option (perhaps
"-prefs") that would just launch the appropriate preferences GUI program.  This
way we could get rid of hardcoding the screensaver and screensaver preferences
GUI commands in the panel code.

Below I am showing the code in gnome-panel which shows the hardcoding of the
screensaver command and the screensaver preferences GUI command.

----

        if (panel_is_program_in_path ("gnome-screensaver-command")
            && panel_is_program_in_path ("gnome-screensaver-preferences"))
                use_gscreensaver = TRUE;
        else if (!panel_is_program_in_path ("xscreensaver-command"))
                return NULL;

        if (strcmp (action, "prefs") == 0) {
                if (use_gscreensaver) {
                        command = g_strdup ("gnome-screensaver-preferences");
                } else if (panel_is_program_in_path ("xscreensaver-demo")) {
                        command = g_strdup ("xscreensaver-demo");
                } else {
                        command = NULL;
                }


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.