[Portland-bugs] [Bug 32924] [PATCH] [xdg-email] xdg-email outputs errors with localized KDE4

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32924

Luc Menut <Luc.Menut at supagro.inra.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #3 from Luc Menut <Luc.Menut at supagro.inra.fr> 2011-01-09 04:31:01 PST ---
(In reply to comment #2)
> Fixed in
> http://cgit.freedesktop.org/portland/xdg-utils/commit/?id=2baf6ae56f9b622ca51aa79ff370676aaef93908
> 
> The committed fix is a bit different from your proposal.

sorry, but I think your fix is wrong; kfmclient_fix_exit_code() is still called
for kde 4, and immediately return 0 in this case, so it always masks the real
exit code of kmailservice for kde 4, which is wrong.

reading more carefully the code, using kfmclient_fix_exit_code() in xdg-email
is probably wrong even for kde 3 since that xdg-email uses kmailservice (in
replacement of kfmclient) and kfmclient_fix_exit_code() is needed to workaround
some bugs in old kfmclient.
# kfmclient exec/openURL can give bogus exit value in KDE <= 3.5.4
# It also always returns 1 in KDE 3.4 and earlier
# Simply return 0 in such case

kfmclient_fix_exit_code() was introduced by Waldo Bastian in xdg-open and
xdg-email (at this time, xdg-email used kfmclient) by this commit:
kfmclient exec exit code is broken in KDE 3.5 series as well.
http://cgit.freedesktop.org/portland/xdg-utils/commit/?id=0420d6906b21694d93264adeba5d1744d044e4e9

later, when kmailservice has replaced kfmclient in xdg-email, the call to
kfmclient_fix_exit_code in xdg-email should probably have been removed.
http://cgit.freedesktop.org/portland/xdg-utils/commit/?id=c4a7764bbe6d2356428dcba4baada9fb1de7b996

I think that "kfmclient_fix_exit_code $1" should be completely removed in
xdg-email now.

for kfmclient_fix_exit_code(),
the line [ x"$KDE_SESSION_VERSION" = x"4" ] && return 0;
is probably useless if kfmclient_fix_exit_code is called only for kde 3.
if you want to keep it, it should be replaced by 
[ x"$KDE_SESSION_VERSION" = x"4" ] && return $1;
in order to not mask the real exit code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.