[Portland-bugs] [Bug 75530] xdg-open behaviour about %i contradicts desktop entry standard

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75530

Olivier Diotte <vhann3000+freedesktop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vhann3000+freedesktop at gmail
                   |                            |.com

--- Comment #4 from Olivier Diotte <vhann3000+freedesktop at gmail.com> ---
Created attachment 107754
  --> https://bugs.freedesktop.org/attachment.cgi?id=107754&action=edit
Patch adding crude handling of %i and %c

I think I have found the problem:

In the function search_desktop_file() of xdg-open, only %[fFuU] is handled. %i
should be replaced by --icon <value of Icon key here>.

Attached is a patch that seems to work for that (and, as a bonus also replaces
%c by the name, although it should technically replace it by the Name[<correct
language>]).

I have tested with bash and bash in 'sh mode'. checkbashisms also doesn't
complain.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/portland-bugs/attachments/20141013/50d4f20b/attachment.html>