[Portland-bugs] [Bug 91758] New: xdg-icon-resource does not support filenames with spaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91758

            Bug ID: 91758
           Summary: xdg-icon-resource does not support filenames with
                    spaces
           Product: Portland
           Version: 1.1.0 rc3
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: xdg-utils
          Assignee: portland-bugs at lists.freedesktop.org
          Reporter: linux at rodrigosilva.com

This is similar to bug #66605 but for xdg-icon-resource this time, and has the
same cause: unquoted var expansions.

Example:
~ $ xdg-icon-resource install --novendor --size 48 "./foo bar.png" foobar
/usr/bin/xdg-icon-resource: 790: [: /home/xxx/foo: unexpected operator

A real scenario is installing icons from software zip/tarballs where the icon
file is in a data dir deep down the archive tree, and paths can not be renamed
as the binary executable might have the path to this data dir hardcoded.

A workaround is to copy the icon to a temp dir before using xdg-icon-resource.

The unquoted var to fix this particular case is $icon_icon_file at line 397 of
xdg-icon-resource.in (
http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-icon-resource.in#n397
) (line 790 in 1.0.2, 953 in 1.1.0 rc3), but there are several other unquoted
var occurrences in code that might also cause trouble.

I'll post 2 patches, one fixing this critical occurrence only, and another one
quoting other vars I've spotted to minimize future issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/portland-bugs/attachments/20150826/80fab4b7/attachment.html>