[Portland-bugs] [Bug 98680] New: xdg-utils detectDE() fails to handle XDG_CURRENT_DESKTOP properly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98680

            Bug ID: 98680
           Summary: xdg-utils detectDE() fails to handle
                    XDG_CURRENT_DESKTOP properly
           Product: Portland
           Version: 1.1.0
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: xdg-utils
          Assignee: portland-bugs at lists.freedesktop.org
          Reporter: mcatanzaro at gnome.org

$XDG_CURRENT_DESKTOP is a list, not a single value. It could be, for instance,
Endless:GNOME or Unity:GNOME, something like that. In cases like these,
detectDE() in xdg-utils-common.in fails to parse $XDG_CURRENT_DESKTOP properly,
since it's only expecting one single value.

This is not really a serious issue now because detectDE() has a fallback to
check $GNOME_DESKTOP_SESSION_ID, but that variable is always set to
this-is-deprecated nowadays and could conceivably disappear in the future. That
could break desktop detection in desktops that want to be treated as GNOME by
xdg-utils. It'd probably be a good idea to use a glob to see if GNOME (or any
other desktop) appears anywhere in the list in the case statement at the start
of detectDE() to avoid this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/portland-bugs/attachments/20161111/e12a8be4/attachment.html>