[Portland-bugs] [Bug 98866] New: do not overwrite environment variable DE if it is already set

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98866

            Bug ID: 98866
           Summary: do not overwrite environment variable DE if it is
                    already set
           Product: Portland
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: xdg-utils
          Assignee: portland-bugs at lists.freedesktop.org
          Reporter: adrelanos at riseup.net

For /usr/bin/xdg-open please do not overwrite environment variable DE if it is
already set.

(That would help us at Qubes OS with some issue.
https://github.com/QubesOS/qubes-issues/issues/2065)

I am suggesting a trivial change.

Now:

```
detectDE

if [ x"$DE" = x"" ]; then
    DE=generic
fi
```

Suggested:

```
if [ x"$DE" = x"" ]; then
    detectDE
fi

if [ x"$DE" = x"" ]; then
    DE=generic
fi
```

What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/portland-bugs/attachments/20161126/b830fd91/attachment.html>