[Portland-bugs] [Bug 106585] New: xdg-open under LXDE treats all URLs as local files

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106585

            Bug ID: 106585
           Summary: xdg-open under LXDE treats all URLs as local files
           Product: Portland
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: xdg-utils
          Assignee: portland-bugs at lists.freedesktop.org
          Reporter: fdeskbugs1 at biz.qcoder.org

First noticed in xdg-utils v1.1.3-1. In xdg-open's function open_lxde(), it's
using shell operator '-a' when it should use '&&'. That causes all URLs to be
opened with pcmanfm, and that's broken for URLs such as https://example.com.

Here's the fix:

--- xdg-open.bad
+++ xdg-open.good
@@ -939,7 +939,7 @@ open_lxde()
 {

     # pcmanfm only knows how to handle file:// urls and filepaths, it seems.
-    if pcmanfm --help >/dev/null 2>&1 -a is_file_url_or_path "$1"; then
+    if pcmanfm --help >/dev/null 2>&1 && is_file_url_or_path "$1"; then
         local file="$(file_url_to_path "$1")"

         # handle relative paths

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/portland-bugs/attachments/20180520/a6e69df3/attachment.html>