xdg-screensaver failure with KDE (was Re: [Portland] Issues with 1.0beta2 and KDE)

[Lubos Lunak]

On Thursday 03 August 2006 22:01, Bastian, Waldo wrote:
> > With these fixes I'm not getting any testsuite failures on SUSE10.1 +
> >KDE3.5.4 except for those caused by the Desktop directory.
>
> Nice.

 One more failure caused by the recent xscreensaver support:
[Po srp  7 15:30:32 CEST 2006] test_screensave_reset: verify screensaver 
reset: FAIL
Command (xdg-screensaver reset) gave exit code 4, expected 0

 Guilty code:
detectDE
# Consider "xscreensaver" a separate DE
xscreensaver-command -version > /dev/null 2> /dev/null && DE="xscreensaver"

 It detects the KDE screensaver as xscreensaver, since it uses some 
xscreensaver properties (probably as support for running xscreensavers with 
it). I suggest the attached patch and also checking other DE's aren't broken 
the same way.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xdg-screensaver.in.patch
Type: text/x-diff
Size: 519 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/portland/attachments/20060807/fb1cf332/xdg-screensaver.in.bin