[Portland] Issues with 1.0beta2 and KDE
Whipple, Tom
tom.whipple at intel.com
Tue Aug 8 13:37:50 PDT 2006
> -----Original Message-----
> From: Lubos Lunak [mailto:l.lunak at suse.cz]
> Sent: Tuesday, August 08, 2006 4:19 AM
> To: Whipple, Tom
> Subject: Re: [Portland] Issues with 1.0beta2 and KDE
>
> On Monday 07 August 2006 22:52, Whipple, Tom wrote:
> > > Uhm, I of course forgot to say the main thing. Although it works
now,
> > > the testsuite still "fails".
> >
> > Hmm. This is because the test is checking for the file in
$HOME/Desktop.
> I
> > will change it to look for a directory called Desktop somewhere
below
> > $HOME.
>
> That's too complicated, and nobody says the directory has to be
called
> Desktop. The proper code should be :
>
> desktop_dir="$HOME/Desktop"
> if test -n "$KDE_FULL_SESSION"; then
> desktop_dir=`kde-config --userpath desktop 2> /dev/null`
> fi
It seems to me 'find $HOME -type d -a -name Desktop' is less
complicated. But, as you point out, that breaks down if the desktop
directory is called something else. I had really hoped that the tests
would run in the same way for all desktops that are tested (no calling
desktop specific utilities), since that's what we are shooting for with
xdg-utils.
> That should work in the testcase, because it's run in the user's
desktop
> and
> it's not su-ed to root (it's not, is it?).
Well, the tests do run as root also, the idea being to test the root
user's desktop. Admittedly, this is not a priority.
-tom
More information about the Portland
mailing list