[Portland] Bug#574131: xdg-utils: xdg-email never launchs a mua if desktop is not gnome neither kde neither xfce

Jonathan Nieder jrnieder at gmail.com
Fri Oct 22 09:15:50 PDT 2010


Jan Braun wrote:

> --- /usr/bin/xdg-email	2010-09-15 13:08:29.000000000 +0200
> +++ ./xdg-email	2010-10-22 09:36:13.000000000 +0200
> @@ -354,7 +354,8 @@
>  
>  detectDE()
>  {
> -    if [ x"$KDE_FULL_SESSION" = x"true" ]; then DE=kde;
> +    if [ x"$MAILER" != x"" ]; then DE=envvar;
> +    elif [ x"$KDE_FULL_SESSION" = x"true" ]; then DE=kde;

Interesting!  I like it.

Nitpicks:

 - I think it would be good to call the envvar XDG_MAILER, because
   (1) the mailer for use in the console may not be the mailer to
   use on the desktop, and (2) it would be nice to leave open the
   possibility of a MAILER variable along the lines of BROWSER with
   more useful semantics in the future.

 - What happens if the mailer contains shell metacharacters?

See http://lists.freedesktop.org/archives/portland/2010-September/001135.html
for a similar attempt (and please feel free to pick and choose what you
like from it).


More information about the Portland mailing list