[pulseaudio-tickets] [PulseAudio] #225: Deadlock/crash in flashsupport closing stream

[PulseAudio]

#225: Deadlock/crash in flashsupport closing stream
------------------------------+---------------------------------------------
  Reporter:  ed at catmur.co.uk  |       Owner:  lennart
      Type:  defect           |      Status:  new    
  Priority:  normal           |   Milestone:         
 Component:  core             |    Severity:  normal 
Resolution:                   |    Keywords:         
------------------------------+---------------------------------------------
Comment (by ed at catmur.co.uk):

 How do I attach a patch?
 {{{
 --- flashsupport.c      2008/01/23 23:36:09     1.1
 +++ flashsupport.c      2008/01/23 23:44:14
 @@ -800,6 +800,7 @@ struct output_data {
      uint8_t buf[BUFSIZE];
      pthread_t thread_id;
      int first;
 +    int signal;
  };

  static void context_state_cb(pa_context *c, void *userdata) {
 @@ -869,6 +870,9 @@ static void write_data(struct output_dat

          l &= ~ ((size_t) 3);

 +        if (p->signal)
 +            return;
 +
          FPI_SoundOutput_FillBuffer(p, (char*) p->buf, l);

          if (pa_stream_write(p->stream, p->buf, l, NULL, 0,
 PA_SEEK_RELATIVE) < 0)
 @@ -1002,6 +1006,8 @@ static int FPX_SoundOutput_Close(void *p

      assert(p);

 +    p->signal = 1;
 +
      if (p->mainloop)
          pa_threaded_mainloop_stop(p->mainloop);

 }}}

-- 
Ticket URL: <http://www.pulseaudio.org/ticket/225#comment:7>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server