[pulseaudio-tickets] [PulseAudio] #407: pulseaudio --dump-resample-methods, always return 1

[PulseAudio]

#407: pulseaudio --dump-resample-methods, always return 1
------------------------------+---------------------------------------------
 Reporter:  hchen59           |       Owner:  lennart
     Type:  defect            |      Status:  new    
 Priority:  low               |   Milestone:         
Component:  daemon            |    Severity:  minor  
 Keywords:  resample methods  |  
------------------------------+---------------------------------------------
 When you run "pulseaudio --dump-resample-methods" to dump available
 resample methods, return value is always 1.

 Peoblem found in pulseaudio-0.9.13

 Correction recommended:
 ======================
 In src/daemon/main.c,
         case PA_CMD_DUMP_RESAMPLE_METHODS: {
             int i;

             for (i = 0; i < PA_RESAMPLER_MAX; i++)
                 if (pa_resample_method_supported(i))
                     printf("%s\n", pa_resample_method_to_string(i));

             goto finish;
         }
 => before "goto finnish", one line to be added "retval = 0" to correct
 this problem.

 Misc:
 =====
 I happened to find this problem, when doing automatic test for PulseAudio,
 by checking return value of PA command-line.

-- 
Ticket URL: <http://www.pulseaudio.org/ticket/407>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server