[pulseaudio-tickets] [PulseAudio] #521: module-combine always uses default sample specs and channel map

PulseAudio trac-noreply at tango.0pointer.de
Wed Apr 1 01:23:50 PDT 2009


#521: module-combine always uses default sample specs and channel map
-------------------------------+--------------------------------------------
  Reporter:  mkbosmans         |       Owner:  lennart
      Type:  enhancement       |      Status:  new    
  Priority:  normal            |   Milestone:  0.9.15 
 Component:  module-combine-*  |    Severity:  normal 
Resolution:                    |    Keywords:         
-------------------------------+--------------------------------------------

Comment(by mkbosmans):

 > Uh, what's the point of '(&ss)->' instead of 'ss.'?
 You caught me, I have no experience in C. I'm one of those high-level
 language application programmers.

 > More problematic is that ss.channels and map.channels need to match up.
 Which they don't with the patch.
 The new patch fixes this and is much cleaner in general.

 I was thinking about adding some logic to make the channel_map of the
 combined sink a superset of all the slave channel_maps. This is probably
 what you want when combining a left,right and a front-left,front-right
 ,rear-left,rear-right sink.[[BR]]
 But in other cases this is not wanted, e.g. combining a left,right and a
 mono sink you would like just a left,right not a three channel combined
 sink. So I think only using the channel_map if there is an exact match
 suffices for now.

-- 
Ticket URL: <http://pulseaudio.org/ticket/521#comment:3>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server


More information about the pulseaudio-bugs mailing list