[pulseaudio-tickets] [PulseAudio] #546: Doesn't compile on the hurd
PulseAudio
trac-noreply at tango.0pointer.de
Sun Apr 19 10:55:04 PDT 2009
#546: Doesn't compile on the hurd
--------------------------+-------------------------------------------------
Reporter: sjoerd | Owner: lennart
Type: enhancement | Status: new
Milestone: | Component: daemon
Resolution: | Keywords:
--------------------------+-------------------------------------------------
Comment(by lennart):
I am generally not opposed to merging this, but I'd like to ask for a
couple of changes first:
Please create seperate wrapper functions for those 'size grow loops'. For
functions like pa_get_home_dir() and pa_get_binary_name() those wrappers
should be in pulsecore/core-util.[ch] so that they can be shared. Please
do not add them to pulse/util.[ch] because we don't want to delute the
external API any further. It would be a good idea to name those wrappers
after the functions they wrap but append a _malloc(). We already have
pa_snprintf() and pa_snprintf_malloc(), thus it would make sense to have
pa_get_home_dir() => pa_get_home_dir_malloc() too, and the same for
pa_get_binary_name() => pa_get_binary_name_malloc().
Regarding PIPE_BUF, please use fpathconf(fd, _PC_PIPE_BUF). That way we
can have the same code path for Linux and Hurd.
Also, the nitpicker who I am prefers for(;;) over while(1).
Otherwise I am happy to merge this.
--
Ticket URL: <http://pulseaudio.org/ticket/546#comment:1>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server
More information about the pulseaudio-bugs
mailing list